Contrib.social

Return type declarations

Open on Drupal.org →
Created on 27 June 2024, 6 months ago
Updated 16 July 2024, 5 months ago

Problem/Motivation

Functions and methods lack clear return type declarations, causing potential type-related errors in the codebase.

Proposed resolution

Add explicit return type declarations to functions and methods to define expected return types clearly. This change improves code clarity, reduces ambiguity, and helps prevent type-related errors.

✨ Feature request
Status

Needs review

Version

2.0

Component

Code

Created by

kuzyawkk

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @kuzyawkk
  • Merge request !183457512: Added return types → (Open) created by kuzyawkk
  • Pipeline finished with Failed
    6 months ago
    Total: 213s
    #209813
  • Pipeline finished with Failed
    6 months ago
    Total: 143s
    #209837
  • Pipeline finished with Success
    6 months ago
    Total: 143s
    #209844
  • Issue was unassigned.
  • Status changed to Needs work 6 months ago
  • Comment 6 months ago →
    kuzyawkk
  • Status changed to Needs review 6 months ago
  • Comment 6 months ago →
    kuzyawkk
  • Status changed to RTBC 5 months ago
  • Comment 5 months ago →
    🇺🇸United States ultimike Florida, USA

    These changes look fine to me, glad to see that the tests that exist are passing, although I would be more comfortable if there was better test coverage for this module.

    Without additional test coverage, I am not comfortable committing these changes based on my eyeballs alone, so I'd prefer to see additional reviews on this change.

    -mike

  • Status changed to Needs review 5 months ago
  • Comment 5 months ago →
    🇺🇸United States ultimike Florida, USA

    I meant to leave this at "Needs review".

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024