- Issue created by @megachriz
- Status changed to Needs work
6 months ago 10:42am 26 June 2024 - 🇳🇱Netherlands megachriz
At least eslint issues are not fixed yet. Perhaps tests fail too on Drupal 11.
- Issue was unassigned.
- Status changed to Needs review
6 months ago 7:22pm 4 July 2024 - 🇳🇱Netherlands megachriz
Alright! All checks pass, tests pass on Drupal 11.
I'm leaving this issue open for a few weeks so others have a chance to review the changes.
-
megachriz →
committed e63b808c on 2.0.x
Issue #3457244 by megachriz: Added Drupal 11 support.
-
megachriz →
committed e63b808c on 2.0.x
- Status changed to Fixed
3 months ago 10:01am 5 October 2024 - 🇳🇱Netherlands megachriz
Retested and checked my code again. All looks good. Merged.
- 🇳🇱Netherlands megachriz
JS tests are failing on Drupal 11 with the following error:
Cannot call non W3C standard command while in W3C mode
This error is triggered by the following code:
$this->getSession()->getDriver()->getWebDriverSession()->element('xpath', $xpath)->location();
Apparently, the method
location()
is not a standard W3C command.It does look like the method
rect()
can also return an element's location, according to https://github.com/jlipps/simple-wd-spec?tab=readme-ov-file#get-element-..., so let's try that. -
megachriz →
committed d4d6bf2d on 2.0.x
Issue #3457244 by megachriz: Fixed JS tests by using the standard W3C...
-
megachriz →
committed d4d6bf2d on 2.0.x
- 🇳🇱Netherlands megachriz
Okay, using
rect()
fixed the JS test failures! Merged. Automatically closed - issue fixed for 2 weeks with no activity.