ImageStyleDownloadController::deliver() signature error

Created on 23 June 2024, 6 months ago

Problem/Motivation

PHP Fatal error: Declaration of Drupal\image_derivative_token\Controller\ImageStyleDownloadController::deliver(Symfony\Component\HttpFoundation\Request $request, $scheme, Drupal\image\ImageStyleInterface $image_style) must be compatible with Drupal\image\Controller\ImageStyleDownloadController::deliver(Symfony\Component\HttpFoundation\Request $request, $scheme, Drupal\image\ImageStyleInterface $image_style, string $required_derivative_scheme)

Apparently this method's signature changed back in January.
https://git.drupalcode.org/project/drupal/-/blob/fd36154396396b44c5c5f48...

Steps to reproduce

I got the error by running drush cr

Proposed resolution

Fix the method signature.

Remaining tasks

Review patch (the introduced variable might be important, the attached patch just forwards it), MR, merge

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

🇭🇺Hungary karol haltenberger

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024