Contrib.social

Fix PHPStan issues and remove D7 code

Open on Drupal.org →
Created on 22 June 2024, 10 months ago
Updated 8 July 2024, 9 months ago

There are only three issues being reported by the default PHPStan settings, which is pretty good!

 ------ ---------------------------------------------------------------------- 
  Line   src/Form/UsfedgovGoogleAnalyticsForm.php                              
 ------ ---------------------------------------------------------------------- 
  82     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
  89     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 ------ --------------------------------------------------------------------- 
  Line   usfedgov_google_analytics.admin.inc                                  
 ------ --------------------------------------------------------------------- 
  263    Function system_settings_form not found.                             
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
 ------ --------------------------------------------------------------------- 
 [ERROR] Found 3 errors

Since one of the errors is an old D7-era function and I know that there is at least one other in the module I'm going to take care of removing that in this issue too.

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇺🇸United States dcam

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024