Fix pipelines

Ok, I understand now that there's .gitlab-ci.yml file in this repo and that configures pipelines. There we have enabled both 9.x and 10.x testing, but even if 9.x would have some issues, why is 10.x failing? It works fine in local?

Tests started failing here

https://git.drupalcode.org/project/permissions_by_term/-/commit/433606fd...

There the .gitlab-ci.yml were edited.

Hi @hkirsman!

I finally found the time to look into this.

I played around with the failing tests a bit.

First of all, I decided to try and disable testing for previous Core versions.

Then I updated the failing tests. They're passing now. I also updated two constant uses again, though I'm not sure about this. Basically, that change would render this issue fork only compatible with Drupal >= 10.3.

So I might roll that back again so we can stay compatible with 10.2.

It would be cool if you could give the version from the issue fork a quick testing spin to see if I accidentally broke anything.

Never mind my last comment about the versions, it was a long day.

Reverted the last commit about the request constants. This will cause problems only when we reach Drupal 11, in which case we should probably spin-off a new major version of the module anyway.

While at this, let's try to fix some coding issues being reported and maybe also include tool like GrumpPHP so we wouldn't see the errors only in Gitlab, but already when committing code?

I ran the code through phpcbf and fixed lot of issues automatically. I've also include comments where needed, but there are still comments missing from in many tests. I'll add more fixes later.

https://git.drupalcode.org/project/permissions_by_term/-/merge_requests/50

Code Quality scans found 3 new findings and 15 fixed findings.
Test summary: 600 failed, 2 errors and 55 fixed test results, 731 total tests

->

Code Quality scans found 4 new findings and 16 fixed findings.
Test summary: 337 failed, 2 errors and 55 fixed test results, 475 total tests

https://git.drupalcode.org/issue/permissions_by_term-3455690/-/jobs/1969500

A TOTAL OF 593 SNIFF VIOLATIONS WERE FOUND IN 48 SOURCES
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 35 MARKED SOURCES AUTOMATICALLY (288 VIOLATIONS IN TOTAL)

->

A TOTAL OF 328 SNIFF VIOLATIONS WERE FOUND IN 20 SOURCES
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SOURCES AUTOMATICALLY (51 VIOLATIONS IN TOTAL)

@marcoliver I don't see this file used anywhere so can I remove it https://git.drupalcode.org/issue/permissions_by_term-3455690/-/blob/3.1.... ?

I've add another batch of coding standard fixes. For this I've written local tool to run the same tests https://github.com/wunderio/drupal-gitlab-local-pipelines It's using https://github.com/phpro/grumphp for running the scans - you can run them on all code base and it triggers on the files being commited. For now I haven't added this as dependency. I wasn't 100% it really does scan exactly the same as there was too much to check, but now near the end it is clear that it's 1:1 for phpcs. Other checkers can be added later, any maybe in some other tasks.

→

We have green phpcs checks!

→