- Issue created by @fago
- First commit to issue fork.
- Merge request !87#3455496: Drop simple and single+simple slot normalization style. → (Merged) created by useernamee
- Assigned to fago
- Status changed to Needs review
5 months ago 11:10am 27 August 2024 - 🇸🇮Slovenia useernamee Ljubljana
I dropped
simple
&simple+single
slot normalization styles.(I've also found
simple+single
normalization style used on one of our internal projects and changed it tosingle
). - 🇦🇹Austria fago Vienna
I've added some comments. It seems this functinoality was not covered by tests, what sucks. It would be nice to add a short test-case to prove single-slot normalization still works correctly, but I guess that would be best a separate issue and is less important. Still, at least let's add the issue?
- Status changed to Needs work
4 months ago 6:05am 29 August 2024 - 🇦🇹Austria fago Vienna
this will need a change record, please prepare a draft
- First commit to issue fork.
- Status changed to Needs review
4 months ago 2:28pm 10 September 2024 - 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
Done:
- Created followup 📌 Add test for single-slot normalization style Active
- Created draft CR. Just said "there is no replacement", as I cannot infer from just the code in the normalizer, how things exactly come out / whether there is a way to get the exact same result.
- Implemented requested changes (with one comment just to be sure, because see previous point).
- Status changed to Fixed
4 months ago 4:08am 11 September 2024 -
fago →
committed 02ccfd6e on 3.x authored by
useernamee →
Issue #3455496 by useernamee, roderik: Drop simple and single+simple...
-
fago →
committed 02ccfd6e on 3.x authored by
useernamee →
Automatically closed - issue fixed for 2 weeks with no activity.