- Issue created by @SteffenR
- Merge request !23#3454344: Misleading version information on /drd/projects page and filters → (Merged) created by SteffenR
- Status changed to Needs review
6 months ago 10:25am 13 June 2024 - First commit to issue fork.
- 🇩🇪Germany jurgenhaas Gottmadingen
Great work @SteffenR, I haven't tested it yet but from looking at the code, this appears to be spot on. Just a minor tweak in the plugin, that I've committed right into it.
WRT the update hook, I wonder if we should really do that. It would silently update the 3 views, without us knowing whether the site owner may have customized their views themselves already. In this case, I'd suggest to deliver the improved views, but leave it to the site owner, whether they want to update them or not. We could add a note to the release notes that a
drush cim --partial --source modules/contrib/drd/config/optional
is recommended. What do you think? - 🇩🇪Germany SteffenR Germany
@jurgenhaas Considering the hook_update_n i was also unsure, but maybe we should remove it and add a note to the release notes.
This would be less intrusive and won't destroys customization.I've updated the MR accordingly and reverted the commit.
- Issue was unassigned.
-
jurgenhaas →
committed 80ac68d8 on 4.1.x authored by
SteffenR →
Issue #3454344: Misleading version information on /drd/projects page and...
-
jurgenhaas →
committed 80ac68d8 on 4.1.x authored by
SteffenR →
- Status changed to Fixed
6 months ago 11:21am 17 June 2024 - 🇩🇪Germany jurgenhaas Gottmadingen
This is looking great, thanks a lot @SteffenR for your contribution. I've just merged this.
Automatically closed - issue fixed for 2 weeks with no activity.