Call to a member function getFilename() on null

Created on 10 June 2024, 18 days ago

Problem/Motivation

When trying to edit a media entity that references an orphaned file entity, the following fatal error occurs:

Error: Call to a member function getFilename() on null in Drupal\media_name\MediaName->mediaEditFormSubmitHandler() (line 98 of /app/drupal/docroot/modules/contrib/media_name/src/MediaName.php).

This happens because MediaName::getMediaFile() can return NULL but its type is not checked.

Steps to reproduce

Create a media entity
Delete its corresponding file entity.
Try to update the media entity to replace the missing file.

Proposed resolution

Check the return value.

🐛 Bug report

Status

RTBC

Version

1.0

Component

Code

Created by

🇧🇬Bulgaria pfrenssen Sofia

Live updates comments and jobs are added and updated live.

Merge Requests

!4Call to a member function getFilename() on null
Open
🇧🇬Bulgaria pfrenssen
updated 18 days ago

Comments & Activities

Issue created by @pfrenssen
Merge request !4Fix call to member function getFilename() on NULL. → (Open) created by pfrenssen
Status changed to Needs review 18 days ago10:14am 10 June 2024
Comment 18 days ago →
🇧🇬Bulgaria pfrenssen Sofia
Status changed to RTBC 18 days ago10:40am 10 June 2024
Comment 18 days ago →
🇨🇭Switzerland tcrawford
Reviewed and the change looks safe. Thanks.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024