Move to GitLab CI

Created on 3 June 2024, 7 months ago
Updated 20 September 2024, 3 months ago

Problem/Motivation

This module is still using Drupal CI for running tests. We need to move to GitLab CI.

Remaining tasks

  • Create MR
  • Verify the tests are being run
  • Create follow-up issues for any code quality failures

User interface changes

None.

API changes

None.

Data model changes

None.

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇳🇱Netherlands eelkeblok Netherlands 🇳🇱

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @eelkeblok
  • Merge request !4Move to Gitlab integration → (Merged) created by eelkeblok
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
    last update 7 months ago
    11 pass
  • 🇳🇱Netherlands eelkeblok Netherlands 🇳🇱

    One part of the tests is causing a problem, although I am puzzled by the apparent Drupal CI result that seems to suggest it is still working. It is this code fragment from Functional/WhoopsTest:

        // Ensures that HttpExceptions not handled by exception subscribers
        // registered before the whoops exception subscriber (e.g when the format
        // is unknown) are caught and reported as whoops error page and the http
        // status code is preserved.
        $this->drupalGet('not-exist', ['query' => ['_format' => 'mhe']]);
        $this->assertSession()->statusCodeEquals(404);
        // This assertion is intentionally shorter than the full text because
        // Drupal 9 and Drupal 10 have slightly different messages.
        $this->assertWhoopsErrorPage('No route found for "GET');
    

    I'll remove that for now and create a new issue to see if it should be restored. It seems reasonable behaviour that a 404 simply loads the 404 page and does not show a Whoops screen.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
    last update 7 months ago
    11 pass
  • Status changed to Needs review 7 months ago
  • 🇳🇱Netherlands eelkeblok Netherlands 🇳🇱
  • Pipeline finished with Skipped
    3 months ago
    #288056
  • Status changed to Fixed 3 months ago
  • 🇳🇱Netherlands eelkeblok Netherlands 🇳🇱
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024