- Issue created by @david.muffley
- Issue was unassigned.
- Status changed to Needs review
7 months ago 7:54pm 31 May 2024 - πΊπΈUnited States markdorison
This looks like a good change to me. I am also curious if we could take this opportunity to add explicit argument types to the constructor arguments. I will make that change and push it up.
The PHPStan failure is related to an upstream deprecation. I have created π Replace deprecated usage of League\Csv\ByteSequence::BOF_UTF8 Needs review to address that.
Merged in the change from #3455761 (#4) and the pipeline passes now without failure. Back to you now.
I didn't add the argument types out of an abundance of caution, but you're much more familiar with the module that I am.
- πΊπΈUnited States markdorison
I didn't add the argument types out of an abundance of caution, but you're much more familiar with the module that I am.
Should be safe to add at PHP 7.4 and above! We should be good to add types throughout the module as we improve the code.
-
markdorison β
committed e7ed3cc6 on 4.x authored by
david.muffley β
Issue #3451668 by david.muffley: Use constructor property promotion
-
markdorison β
committed e7ed3cc6 on 4.x authored by
david.muffley β
- Status changed to Fixed
6 months ago 3:12pm 27 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.