Contrib.social

Fix schema for ad_entity.settings, ad_entity_adtech_v2, ad_entity_adtech and ad_entity_dfp

Open on Drupal.org →
Created on 29 May 2024, 8 months ago
Updated 3 September 2024, 4 months ago

Problem/Motivation

Configuration inspector reported that the schema for ad_entity, ad_entity_adtech_v2, ad_entity_adtech and ad_entity_dfp is invalid. The issue with ad_entity_adtech_v2 is that inside the schema definition it's missing the third party settings definition.

For ad_entity_adtech and dfp the issue is that they both have settings in the main ad_entity.settings configuration. The inspector couldn't validate this.

Steps to reproduce

  • Install ad_entity, ad_entity_adtech_v2, ad_entity_adtech and ad_entity_dfp
  • Set some settings for these, add some entities, doesn't matter as long as some settings exist.
  • Install drupal/config_inspector and enable it.
  • Run the config inspector and go to /admin/reports/config-inspector
  • You should now see the errors produced by the schema

    • Proposed resolution

    For ad_entity_adtech_v2 just add to the schema the missing third_party settings schema.

    For the sub modules that add keys to the main module's ad_entity.settings configuration we need to use hook_config_schema_info_alter(). This is because the schema for this configuration does not belong to the sub modules. Also, we need to ensure the config keys are removed from this config on uninstall.

    Update functions have been written to update existing configuration so that it conforms with the schema.

    Remaining tasks

    None.

    User interface changes

    None

    API changes

    None

    Data model changes

    None

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇸🇮Slovenia miha.wagner

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024