Missing GTM ID causes PHP warning: passing null to parameter #2 of preg_match deprecated in TagContainer.php

Created on 27 May 2024, 7 months ago

Updated 8 August 2024, 4 months ago

Problem/Motivation

Deprecated function: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in Drupal\google_tag\Entity\TagContainer::Drupal\google_tag\Entity\{closure}() (line 210 of modules/contrib/google_tag/src/Entity/TagContainer.php).

Steps to reproduce

PHP warning visible on any page as long as no GTM ID is saved.

Proposed resolution

Prepending is_string($id) && to preg_match. See patch.

🐛 Bug report

Status

Fixed

Version

2.0

Component

Code

Created by

🇧🇪Belgium jummonk

Live updates comments and jobs are added and updated live.

Merge Requests

!90Missing GTM ID causes PHP warning: passing null to parameter #2 of preg_match deprecated in TagContainer.php
Merged
🇺🇸United States japerry
updated 5 months ago

Comments & Activities

Issue created by @jummonk
Comment 7 months ago →
🇧🇪Belgium jummonk
First commit to issue fork.
Merge request !90Issue #3450154: Missing GTM ID causes PHP warning: passing null to parameter... → (Merged) created by japerry
Pipeline finished with Skipped
5 months ago
#234257
Status changed to Fixed 5 months ago10:48pm 25 July 2024
Comment 5 months ago →
System Message

japerry → committed 7b155beb on 2.0.x
Issue #3450154: Missing GTM ID causes PHP warning: passing null to...
Comment 5 months ago →
🇺🇸United States japerry KVUO
Comment 4 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024