- Issue created by @geek-merlin
- last update
11 months ago 794 pass - Status changed to Needs review
11 months ago 5:43pm 25 May 2024 - last update
10 months ago 794 pass - 🇮🇱Israel jsacksick
Are you sure this is the only place that is problematic to support this? There's probably plenty of code assuming variation types are returned by $product_type->getVariationTypeIds().
- 🇩🇪Germany geek-merlin Freiburg, Germany
Hey Jonathan,
> Are you sure this is the only place that is problematic to support this? There's probably plenty of code assuming variation types are returned by $product_type->getVariationTypeIds().Short: Yes.
Long version: I'm running this on a critical site and don't want to shoot me in the foot. So i checked all usages of said method (only 10-ish, most in foreach), and robustified the 3 places where it coughs.
Now i rebased and simplified the MR, re-applied it on my site, and verified all integration tests are still green.
- Merge request !369Do not cough on product with no variation types (onto 3.0.x) → (Open) created by geek-merlin
- 🇩🇪Germany geek-merlin Freiburg, Germany
Added 3.0.x MR too.
@jsacksick See #6.
- 🇩🇪Germany geek-merlin Freiburg, Germany
The only change in 3.0.x was due to the nice simplification in 📌 Remove the variationType setting Fixed .
- 🇮🇱Israel jsacksick
Would be great if we could get additional tests to demonstrate the failure... Also don't want to shoot myself in the foot here :)... As this is really an edge case.
- 🇩🇪Germany geek-merlin Freiburg, Germany
Not sure when, but challenge taken.