Review doesn't install dependencies

Created on 24 May 2024, about 1 month ago

Problem/Motivation

There can be a lot of errors because the review script doesn't download module dependencies.

Steps to reproduce

The script doesn't recognize classes/methods from dependencies.

$ ./pareview.sh https://git.drupalcode.org/project/facets_taxonomy_multilevel 1.0.x

Review of the 1.0.x branch (commit 472bd13):
[...]
 ------ ---------------------------------------------------------------------------------------------------------------
  Line   pareview_temp/src/Plugin/facets/processor/TermDependent.php
 ------ ---------------------------------------------------------------------------------------------------------------
  28     Class Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDependent extends unknown class
         Drupal\facets\Processor\ProcessorPluginBase.
         πŸ’‘ Learn more at https://phpstan.org/user-guide/discovering-symbols
  28     Class Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDependent implements unknown interface
         Drupal\facets\Processor\BuildProcessorInterface.
         πŸ’‘ Learn more at https://phpstan.org/user-guide/discovering-symbols
  69     Parameter $facets_manager of method
         Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDependent::__construct() has invalid type
         Drupal\facets\FacetManager\DefaultFacetManager.
  70     Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDependent::__construct() calls
         parent::__construct() but Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDependent does not
         extend any class.
  95     Parameter $current_facet of method
         Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDependent::buildConfigurationForm() has invalid
         type Drupal\facets\FacetInterface.
  98     Call to an undefined method
         Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDependent::getConfiguration().
  115    Call to an undefined method Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDependent::t().
  121    Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDependent::buildConfigurationForm() calls
         parent::buildConfigurationForm() but Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDependent
         does not extend any class.
  127    Parameter $facet of method Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDependent::build()
         has invalid type Drupal\facets\FacetInterface.
  128    Call to an undefined method
         Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDependent::getConfiguration().
 ------ ---------------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------------
  Line   pareview_temp/src/Plugin/facets/processor/TermDepth.php
 ------ ---------------------------------------------------------------------------------------------------------------
  27     Class Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDepth extends unknown class
         Drupal\facets\Processor\ProcessorPluginBase.
         πŸ’‘ Learn more at https://phpstan.org/user-guide/discovering-symbols
  27     Class Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDepth implements unknown interface
         Drupal\facets\Processor\BuildProcessorInterface.
         πŸ’‘ Learn more at https://phpstan.org/user-guide/discovering-symbols
  67     Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDepth::__construct() calls
         parent::__construct() but Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDepth does not extend
         any class.
  90     Parameter $facet of method
         Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDepth::buildConfigurationForm() has invalid
         type Drupal\facets\FacetInterface.
  92     Call to an undefined method
         Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDepth::getPluginId().
  96     Call to an undefined method Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDepth::t().
  100    Call to an undefined method Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDepth::t().
  111    Call to an undefined method Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDepth::t().
  113    Call to an undefined method Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDepth::t().
  123    Parameter $facet of method Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDepth::build() has
         invalid type Drupal\facets\FacetInterface.
  125    Call to an undefined method
         Drupal\facets_taxonomy_multilevel\Plugin\facets\processor\TermDepth::getPluginId().
 ------ ---------------------------------------------------------------------------------------------------------------

 [ERROR] Found 21 errors

Proposed resolution

Would it be feasible to run composer install in the temp folder?

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Active

Version

1.0

Component

Default

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024