- Issue created by @andreastkdf
- Assigned to scott_euser
- Status changed to Needs review
8 months ago 11:59am 23 May 2024 - Status changed to Needs work
8 months ago 6:39pm 3 June 2024 - Assigned to andreastkdf
- Status changed to Postponed
7 months ago 5:02pm 4 July 2024 - 🇬🇧United Kingdom scott_euser
Going to postpone this until we get things pluggable first 📌 Refactor to allow multiple puppeteer services Fixed
- Status changed to Needs work
7 months ago 10:02pm 4 July 2024 - 🇬🇧United Kingdom andreastkdf
Following https://www.drupal.org/project/page_to_pdf/issues/3459121 📌 Refactor to allow multiple puppeteer services Fixed (thanks!), the MR of this issue now contains updates following the new plugin structure. New generators for each service (doppio or browserless) are implemented. This also includes some other general fixes.
Updated README for setup instructions.
Note that for both services, their API key can be added on settings.local with:
$settings['page_to_pdf_api_key'] = API_KEY
Finally, not very important, I also wonder if we should refactor the project and substitute 'Puppeteer" with "PDF_service" on labels and variable names to reflect the latest changes that are tool-agnostic; it's basically now flexible to use external services that generate PDFs.
- Status changed to Needs review
6 months ago 1:14am 3 August 2024 - Status changed to Needs work
6 months ago 6:53am 3 August 2024 - Status changed to Needs review
5 months ago 6:13pm 13 August 2024 - 🇬🇧United Kingdom scott_euser
Great this looks good thanks! Can you confirm that PDFs still generate with browserless.io with this MR please? If so, I'll merge
- 🇬🇧United Kingdom andreastkdf
thanks Scott! yes, I've tested with both services :)
-
scott_euser →
committed 408d59dd on 1.0.x authored by
andreastkdf →
Issue #3449345 by andreastkdf, scott_euser: Give option to use Doppio...
-
scott_euser →
committed 408d59dd on 1.0.x authored by
andreastkdf →
- Issue was unassigned.
- Status changed to Fixed
5 months ago 4:43am 15 August 2024 - 🇬🇧United Kingdom scott_euser
Excellent thank you! Will make a new release shortly
Automatically closed - issue fixed for 2 weeks with no activity.