- Issue created by @roderik
- Status changed to Needs review
24 days ago 6:09pm 23 May 2024 - 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
This MR in principle is only a single commit at the moment (the last one).
In practice it includes https://git.drupalcode.org/project/custom_elements/-/merge_requests/65 == 📌 Replace twitter, video and image processors Needs review ; I can rebase it after that is reviewed.
(Or I can just push the last commit onto MR 65 if you want to not review that one standalone.)
- Status changed to Needs work
23 days ago 8:25am 24 May 2024 - 🇦🇹Austria fago Vienna
as discussed we want to move this to a separate formater first
- Status changed to Needs review
23 days ago 2:44pm 24 May 2024 - Status changed to Needs work
23 days ago 3:34pm 24 May 2024 - 🇦🇹Austria fago Vienna
thx, looks great, merged!
I only had one comment, which could be added in a small follow-up PR if you agree.
Else, I'd suggest to add another small follow-up for introducing a new config option into the field/image formatter if the reference points to an image: An image-style drop-down.
That would be handy for media-references pointing to media-iamges as well, but I guess this should be its own follow-up.
Setting to needs-work for reading my comment and deciding how to continue!