Refactor the JavaScript for the widget to use the once library

Ready for review.

Thanks, I was aware that there was some technical debt/errors in the code.
I will need to process the patch bit by bit, to check what has changed, and learn from it.

When code is reviewed, there are comments about unnamed functions, so I will keep the function name in attach: function doUpdateElement(context) {

I went through all changes, and understood and copied all but one:
The following patch is still pending, since adding it breaks the following scenario (testing with dev-version):
- enable Exceptions in field settings, using the correct Widget.
- Push the 'Add exception' button. Then an element is rebuilt by a Ajax call. after that, the JS-links are broken.
- You may still add an exception and save the node.
- Now reopen the node, and see that without pressing 'Add exception', the exception's JS-links are fine, but broken after pressing the button.

Thanks for your work!

diff --git a/js/office_hours.js b/js/office_hours.js
index b25721f..07a596a 100644
--- a/js/office_hours.js
+++ b/js/office_hours.js
@@ -203,7 +203,7 @@
 
   Drupal.behaviors.office_hours = {
     attach: function doUpdateElement(context) {
-     $(document).ready(function prepareElements() {
+     $(once('office-hours', '.field--type-office-hours', context)).each(function prepareElements() {
         // Attach a function to each JS link and initialize if needed.
         // N.B.: using * wildcard, since initially, no suffix is added,
         // but after 'Add exception'button, a suffix is added to the ID.

The past commit contains similar changes to js/office_hours_status_update.js.
Please check that file.

I added the 'data-drupal-selector' to the code in 📌 Use not-randomized drupal-data-selector, not #id Fixed and I credited you for that.

After merge of the changes made up until 1.19, there was not much left but swapping out the $(document).ready with the once().

That, also seems to fix 🐛 Additional slot row disappears after value change when used in nested paragraphs Needs work . I tested with a field in

1. Tabs
2. Details
3. A Paragraph
4. A Paragraph in Details

I forgot the exception case, that is still broken.

I've updated the script to

1. Apply all the initialisation and event handler binding per slot/row instead of the entire table at once. This makes sure new rows added by Ajax get the required processing. The 'once' at field level was blocking this.
2. The striping fix was kept at field level, but it just occurs to me that I didn't check if that needs to be rerun after an exception is added, or when using the list widget.

Also
if ($nextTr.is(':hidden')) {
didn't work anymore for some reason, so I changed it to
if ($nextTr.hasClass('js-office-hours-hide')) {
which seems to have the same effect as far as I can tell.

I've updated the script to

1. Apply all the initialisation and event handler binding per slot/row instead of the entire table at once. This makes sure new rows added by Ajax get the required processing. The 'once' at field level was blocking this.
2. The striping fix was kept at field level, but it just occurs to me that I didn't check if that needs to be rerun after an exception is added, or when using the list widget.

Also
if ($nextTr.is(':hidden')) {
didn't work anymore for some reason, so I changed it to
if ($nextTr.hasClass('js-office-hours-hide')) {
which seems to have the same effect as far as I can tell.

Thanks a lot. The fix seems to address the problem. Committed.

Automatically closed - issue fixed for 2 weeks with no activity.

Hi Andrews, do you want to reppen this issue?
I have changed the relevant code fase today.

No, was just a test to see if changing the issue credits assignment would stick, as a thank you for the work done.

I can, and did, as a maintainer.

I only recently found out that crediys do no oly go via commits, but also the issues themselves.

Thanks!