Contrib.social

Settings form breaks with Leaflet 10.2.14

Open on Drupal.org →
Created on 21 May 2024, 7 months ago
Updated 6 June 2024, 6 months ago

Problem/Motivation

When upgrading Leaflet module to 10.2.14 breaks this module. Settings form when editing the Views style shows no settings, and simply says

Please add at least one Geofield to the View and come back here to set it as Data Source.

This line in the leaflet_views style plugin:
https://git.drupalcode.org/project/leaflet/-/blob/10.2.x/modules/leaflet...

Has changed from "static" to "self"

I created a patch for the temporary in case people need something while waiting on permanent solution/release
https://git.drupalcode.org/project/civicrm_entity_leaflet/-/merge_reques...

This commit broke it: https://git.drupalcode.org/project/leaflet/-/commit/f5a756c14a86e9f24ba4...

🐛 Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

🇺🇸United States markusa

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @markusa
  • Comment 7 months ago →
    🇺🇸United States markusa

    Confirmed the MR works with both 10.2.13 (before change) and 10.2.14 (after change)

    I'm not sure how far back that fix will work for, the create() method we're adding to the extended object, from the original, has been in its current form for 4 years, other than the change from "static" to "self"

    Should actually work for much older versions then.

    I'm inclined to merge this MR

  • Comment 6 months ago →
    🇺🇸United States markusa

    The MR was merged

  • Status changed to Fixed 6 months ago
  • Comment 6 months ago →
    🇺🇸United States markusa
  • Comment 6 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024