Filter settings override in url_embed.schema.yml breaks filter settings

Open on Drupal.org →

Created on 21 May 2024, 7 months ago

Updated 11 June 2024, 6 months ago

Problem/motivation

As "url_embed" overrides "filter_settings.*" with type "mapping", whereas the original type is "sequence", in "url_embed.schema.yml" it breaks other filter_settings.

Steps to reproduce

With URL Embed enabled go to /admin/config/content/formats and edit or create a format
Try to add media embed for CKEditor 5, and save.
A long list of errors like "'allowed_media_types' is not a supported key." will occur, and the format can not be save.

Proposed resolution

Remove the "filter_settings.*" override in "url_embed.schema.yml" and replace "filter_settings.url_embed_convert_links" type "sequence" with "filter" as that seems to be the correct way to declare filter_settings.
I've added a patch file to this issue.

This module uses Gitlab CI for automated testing of proposed code changes. To contribute code changes, create a merge request. Patch files will not trigger automated testing and are not sufficient for review.

🐛 Bug report

Status

Fixed

Version

3.0

Component

Code

Created by

flemming.fridthjof

Live updates comments and jobs are added and updated live.

filter settings filter_settings schema

Sign in to follow issues

Merge Requests

!17Filter settings override in url_embed.schema.yml breaks filter settings
Merged
🇺🇸United States mark_fullmer
updated 7 months ago

Comments & Activities

Issue created by @flemming.fridthjof
First commit to issue fork.
Merge request !17Issue #3448488 by flemming.fridthjof: Filter settings override in... → (Merged) created by mark_fullmer
Status changed to RTBC 7 months ago10:03pm 28 May 2024
Comment 7 months ago →
🇺🇸United States mark_fullmer Tucson
Thanks for the catch! This makes sense and comports with the syntax used in Drupal core & elsewhere for filter format settings.
Pipeline finished with Skipped
7 months ago
#184519
Comment 7 months ago →
System Message

mark_fullmer → committed ecc1f574 on 3.x
Issue #3448488 by flemming.fridthjof: Filter settings override in...
Status changed to Fixed 7 months ago10:09pm 28 May 2024
Comment 7 months ago →
🇺🇸United States mark_fullmer Tucson
Tests are failing as expected: "current major" has an issue with Twitter output, and "next major" does not have a compatible version of drupal/embed to use. Proceeding to merge, as 3.x is in alpha currently, anyway.
Comment 6 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024