- Issue created by @gpietrzak
- Status changed to Closed: duplicate
7 months ago 12:53pm 21 May 2024 - 🇵🇱Poland gpietrzak Wrocław
Fixed in https://www.drupal.org/project/advanced_mautic_integration/issues/3448523 📌 Set up CI/CD pipelines Fixed
Using branch 1.0.x there is a few code style issues in the javascript library. You may also want to run this by eslint.
$ phpcs --standard=Drupal,DrupalPractice advanced_mautic_integration
FILE: ...html/web/modules/contrib/advanced_mautic_integration/js/tracking_events.js
--------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
48 | ERROR | [x] Expected 1 space before "?"; 0 found
48 | ERROR | [x] Expected 1 space after "?"; 0 found
48 | ERROR | [x] Expected 1 space before ":"; 0 found
48 | ERROR | [x] Expected 1 space after ":"; 0 found
56 | ERROR | [x] Expected 1 space before "?"; 0 found
56 | ERROR | [x] Expected 1 space after "?"; 0 found
56 | ERROR | [x] Expected 1 space before "?"; 0 found
56 | ERROR | [x] Expected 1 space after "?"; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 148ms; Memory: 6MB
Closed: duplicate
1.0
Code
Fixed in https://www.drupal.org/project/advanced_mautic_integration/issues/3448523 📌 Set up CI/CD pipelines Fixed