- Issue created by @gpietrzak
Wondering if some of the `private` vars should be `protected`
public function __construct(
private readonly ConfigFactoryInterface $configFactory,
private readonly MauticApiWrapperInterface $apiWrapper,
private readonly AccountProxyInterface $currentUser,
private readonly RequestStack $requestStack,
) {}
Or is the expectation that UserSynchronizer should be extensible and these should be visible to any child classes? I don't know what the plans are but I would tend to default to the most restrictive unless you need something more open. Same thing for the other classes where private is used, such as the VisibilityTracker class.
This should be aligned with writing module tests.
Active
1.0
Code