Fix unlocking body scroll after closing the popup on drupal > 10.2.x

Created on 16 May 2024, about 2 months ago

Problem/Motivation

Closing the popup keeps the body locked against scrolling.
This started happening since introducing the body scroll lock in drupal core dialog(10.2.x).

Steps to reproduce

use drupal 10.2.5
Add a popup on load
Navigate to the page
Try to close the popup and the page will stay locked

Proposed resolution

Removing the empty close callback so that it could be handled by the default callback which will unlock scrolling on close.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Needs review

Version

1.0

Component

Code

Created by

🇯🇴Jordan Abdelrahman khlefat

Live updates comments and jobs are added and updated live.

Merge Requests

!3Fix unlocking body scroll after closing the popup on drupal > 10.2.x
Open
🇯🇴Jordan Abdelrahman khlefat
updated about 2 months ago

Comments & Activities

Issue created by @Abdelrahman khlefat
Merge request !3Issue #3447639: Fix scroll lock → (Open) created by Abdelrahman khlefat
Comment about 2 months ago →
🇯🇴Jordan Abdelrahman khlefat
Uploading a patch file for composer
Issue was unassigned.
Status changed to Needs review about 2 months ago3:35pm 16 May 2024

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024