Project update bot did not create 11 update issue for Rest Views

Created on 15 May 2024, about 1 month ago
Updated 6 June 2024, 11 days ago

Problem/Motivation

Rest views did not get the automated fix issue:
https://www.drupal.org/project/issues/rest_views?text=&status=All&priori... β†’

https://dev.acquia.com/drupal11/deprecation_status/projects/rest_views
https://git.drupalcode.org/project/project_analysis/-/tree/results-d11/r...

Steps to reproduce

N/A

Proposed resolution

@bbrala mentioned in slack he will review logs.

Remaining tasks

Fix issue with rest views.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

πŸ› Bug report
Status

Needs review

Component

Miscellaneous

Created by

πŸ‡ΊπŸ‡ΈUnited States nicxvan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @nicxvan
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    I've noticed some other modules that don't seem to have the auto issue created either:

    https://www.drupal.org/project/issues/shortcode β†’

  • πŸ‡³πŸ‡±Netherlands bbrala Netherlands

    For rest views in latest i do see an unfixable error:

    file name="modules/contrib/rest_views/rest_views.module"><error line="85" message="Call to deprecated method getName() of class Drupal\Core\Extension\ModuleHandlerInterface. Deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. Use Drupal::service('extension.list.module')-&gt;getName($module) instead." severity="info"/></file>
    

    We don't have rector support for that.

  • πŸ‡³πŸ‡±Netherlands bbrala Netherlands

    Same for shortcode:

    <file name="modules/contrib/shortcode/src/Plugin/ShortcodeBase.php"><error line="403" message="Call to deprecated method renderPlain() of class Drupal\Core\Render\RendererInterface. Deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. Use Drupal\Core\Render\RendererInterface::renderInIsolation() instead." severity="info"/></file>
    

    Other deprecation though.

  • Status changed to Needs review about 1 month ago
  • πŸ‡³πŸ‡±Netherlands bbrala Netherlands
  • Status changed to Needs work about 1 month ago
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    Thank you for reviewing!

    I have two follow up questions:
    1. I thought the expected behavior in this case is to open the issue in the respective queue and leave a comment that those are unfixable rather than no issue at all.
    2. Both of these deprecations are marked as not being removed until Drupal 12, they should not impact Drupal 11 readiness, what causes them to be unfixable if rector doesn't need to change anything?

    Thanks!

  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    Hi, do you have any feedback for my questions?

  • πŸ‡³πŸ‡±Netherlands bbrala Netherlands
    1. Issue is made if there were fixes were made, even if not totally compatible. We don't make an issue without an patch.
    2. Handling of that case is something it doesn't do. We need to fix that. Making a child issue.
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    Hmm, both of these modules got the automated fix, but there is no mention of the getName Deprecation, it's just bumping the version now.

  • Status changed to Needs review 11 days ago
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    Ah I see, you fixed the issue where it was breaking on 12.0 deprecations thanks!

    I think this can be closed, but leaving in review for you.

Production build 0.69.0 2024