- Issue created by @nicxvan
- πΊπΈUnited States nicxvan
I've noticed some other modules that don't seem to have the auto issue created either:
- π³π±Netherlands bbrala Netherlands
For rest views in latest i do see an unfixable error:
file name="modules/contrib/rest_views/rest_views.module"><error line="85" message="Call to deprecated method getName() of class Drupal\Core\Extension\ModuleHandlerInterface. Deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. Use Drupal::service('extension.list.module')->getName($module) instead." severity="info"/></file>
We don't have rector support for that.
- π³π±Netherlands bbrala Netherlands
Same for shortcode:
<file name="modules/contrib/shortcode/src/Plugin/ShortcodeBase.php"><error line="403" message="Call to deprecated method renderPlain() of class Drupal\Core\Render\RendererInterface. Deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. Use Drupal\Core\Render\RendererInterface::renderInIsolation() instead." severity="info"/></file>
Other deprecation though.
- Status changed to Needs review
11 months ago 8:25am 17 May 2024 - Status changed to Needs work
11 months ago 1:05pm 17 May 2024 - πΊπΈUnited States nicxvan
Thank you for reviewing!
I have two follow up questions:
1. I thought the expected behavior in this case is to open the issue in the respective queue and leave a comment that those are unfixable rather than no issue at all.
2. Both of these deprecations are marked as not being removed until Drupal 12, they should not impact Drupal 11 readiness, what causes them to be unfixable if rector doesn't need to change anything?Thanks!
- πΊπΈUnited States nicxvan
Hi, do you have any feedback for my questions?
- π³π±Netherlands bbrala Netherlands
- Issue is made if there were fixes were made, even if not totally compatible. We don't make an issue without an patch.
- Handling of that case is something it doesn't do. We need to fix that. Making a child issue.
- πΊπΈUnited States nicxvan
Hmm, both of these modules got the automated fix, but there is no mention of the getName Deprecation, it's just bumping the version now.
- Status changed to Needs review
10 months ago 8:27pm 6 June 2024 - πΊπΈUnited States nicxvan
Ah I see, you fixed the issue where it was breaking on 12.0 deprecations thanks!
I think this can be closed, but leaving in review for you.