Remove undefined item condition in primary menu template

This may not be so simple.

It seems that, while the item variable is as yet undefined for the top portion, it is effectively acting as a default setter for link_attributes, necessary for the if duplicate_parent statement just below it.

So, keep the parent.url.getOption('attributes') and perform the set menu_item_type = 'link' at the outset.

I see what you mean... this was a change submitted a few years ago. If link was needed initially, then you may as well get rid of the rest of the if and elseif sections. Removing the rest and only having what is in else would be effectively doing the exact same thing.

This should be simple and I'd only consider it a clean-up rather than a bug. **Since it hasn't caused issues for the years being there, I'm going to re-classify this issue.

Did you want to make the change?

Yeah, if you’re on board for it being just a clean up, this is a great first issue, and I’ve got a colleague I’d like to mentor on the process.

Hoped for that scenario. Sounds good... there's a few other issues that seem more like clean-up related items. I'll most likely roll all of them into a 3.7.2 release.

Regardless, I'll try to dig into this further when I review for 3.8.x. After 2 years of no one saying anything about this, no reason to overthink it right now.