Remove some once compat methods for core/once

Created on 14 May 2024, 11 months ago

Updated 28 May 2024, 10 months ago

Problem/Motivation

The library core/once was included in D9.2, see https://www.drupal.org/node/3158256 → .
Blazy 3.x was previously planned to depend on D9.2, however to minimize PHP7 compat issues, a minimum D9.4 is required.
Thus, core/once is already in Blazy 3.x lifespan.

Blazy 2.x copied methods of core/once for easy migration into 3.x while staying compatible with D8.8 where jQuery.once was the deprecated solution.

One issue to watch out for is:

window.once namespace change into Drupal.once:
🐛 window.once name conflict with other third party script Needs work .
However this should be easily fixed by including them both.

Proposed resolution

Remove copied methods, extend core/once and keep the current functionality to minimal disruptions.

Remaining tasks

Write a patch.

User interface changes

None.

API changes

None. The existing onceCompat was designed since 2.x to be interchangeable with core/once with some BC and an extra callback function to avoid repeated loop of elements usage.

Data model changes

None.

📌 Task

Status

Fixed

Version

3.0

Component

JavaScript

Created by

🇮🇩Indonesia gausarts

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @gausarts
Status changed to Needs review 11 months ago5:30am 14 May 2024
Comment 11 months ago →
🇮🇩Indonesia gausarts
Also noticed a more strict check with undefined ID check for pinterest which is good.

Comment 11 months ago →

System Message

gausarts → committed 811670c0 on 3.0.x

Issue #3446991 by gausarts: Remove some once compat methods for core/...

Status changed to Fixed 11 months ago5:38am 14 May 2024
Comment 11 months ago →
🇮🇩Indonesia gausarts
It was a @todo, and is done now.

This will do for now.

If any issue with this change, we'll fix it later.

Thank you.
Comment 10 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024