Support views default display

Created on 13 May 2024, 7 months ago

In facets 3.x, we are adding better support for views in a new submodule.
See 📌 Rewrite facets exposed filters to be native views filters. Active

Since users can enable showing the views default display in views UI, we need support for this plugin type too.

Can we add this plugin type in search api?

📌 Task
Status

Active

Version

1.0

Component

General code

Created by

🇧🇪Belgium StryKaizer Belgium

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @StryKaizer
  • Pipeline finished with Success
    7 months ago
    Total: 359s
    #171669
  • Status changed to Postponed: needs info 7 months ago
  • 🇦🇹Austria drunken monkey Vienna, Austria

    The approach seems interesting. However, when the facet is just an exposed filter on the view, does it really still make sense to base any of this on the Search API display plugins? It seems to me like that would have little benefit, while potentially causing issues (or at least confusion) when an exposed filter on the default display is then executed for, say, the page display, but still associated to a ViewsDefault display plugin.

    I’m also worried that adding this display might cause issues for other modules that use Search API display plugins. The new options that appear for those modules (say, Autocomplete) might confuse users, especially inexperienced ones. It also might give the impression that configuration done for the default display will also apply to other displays for that view, even though that’s of course generally not the case. (On the contrary, for a lot of use cases the configuration done for the default display might be completely useless.)

    If the new plugin type is really necessary, could we at least hide it if the user hasn’t enabled the “Always show the default display” option in Views?

  • 🇧🇪Belgium StryKaizer Belgium

    It makes sense to not expose this to users.

    I need it to support every display at once (since views uses the default display for every filter as default, unless that display has its filters overridden).
    I'll just move this issue to the facets queue and provide the plugin in the new facets_exposed_filters submodule instead.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024