Tokens in subtree links are not replaced

Created on 10 May 2024, 9 months ago

Problem/Motivation

Tokens in subtree links are not replaced.

Steps to reproduce

Go to /admin/structure/menu/manage/main and create a menu item.
Create a second menu item as follows:
- Set the Link field to a path that contains a token.
- Check the box for "Use tokens in title and in path" and configure context.
- Set the first menu item as this item's parent.
Rebuild cache.
Refresh /admin/structure/menu/manage/main.
Inspect the child link.

Expected result: The token is replaced in the child link's URL.
Actual result: The token is not replaced.

Proposed resolution

The problem is in \Drupal\menu_token\Service\MenuLinkTreeMenuToken::replaceLinkUrls. This method loops through the menu tree, but does not check each link's subtree value; thus, only top-level links are replaced. This can be solved by recursing through the subtree (if it is not empty).

🐛 Bug report

Status

Needs review

Version

9.1

Component

Code

Created by

🇺🇸United States muriqui

Live updates comments and jobs are added and updated live.

Merge Requests

!18Tokens in subtree links are not replaced
Open
🇺🇸United States muriqui
updated 9 months ago

Comments & Activities

Issue created by @muriqui
Merge request !18Issue #3446513: Fix tokens in subtree links not being replaced. → (Open) created by muriqui
Status changed to Needs review 9 months ago1:53pm 10 May 2024
Comment 9 months ago →
🇺🇸United States muriqui

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024