- Issue created by @andreasderijcke
- 🇪🇸Spain fjgarlin
The error comes because there is markup in the comment here: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...
Now I can work on a fix.
- Status changed to Needs work
8 months ago 8:18pm 8 May 2024 - 🇪🇸Spain fjgarlin
So, the comments in that file introduce unexpected markup, which breaks the rest of the tags.
I made a quick fix, but it does break a good number of tests, so I need to look into detail.
Pipeline with the fix: https://git.drupalcode.org/project/api/-/pipelines/167813 (broken)
Pipeline without the fix: https://git.drupalcode.org/project/api/-/pipelines/167827 (working) - Status changed to Needs review
8 months ago 10:41pm 8 May 2024 - 🇪🇸Spain fjgarlin
MR is green now. I'm going to deploy this shortly to our staging environment.
-
fjgarlin →
committed 4bbe3f5f on 2.x
Issue #3446010 by fjgarlin, andreasderijcke: Container.php/class/...
-
fjgarlin →
committed 4bbe3f5f on 2.x
- Assigned to fjgarlin
- 🇪🇸Spain fjgarlin
I tried in the stage site and is still not working: https://api.stage.cluster.drupalsystems.org/api/drupal/core%21lib%21Drup...
I'll continue working on it.
- 🇪🇸Spain fjgarlin
https://git.drupalcode.org/project/api/-/merge_requests/31/diffs introduces a new command to reparse just one file, instead of the whole branch. In this case, we can just reparse the offending file and the previously merged commit should fix the problem.
-
fjgarlin →
committed f3501793 on 2.x
Issue #3446010 by fjgarlin, andreasderijcke: Container.php/class/...
-
fjgarlin →
committed f3501793 on 2.x
-
fjgarlin →
committed 42c54386 on 2.x
Issue #3446010 by fjgarlin, andreasderijcke: Container.php/class/...
-
fjgarlin →
committed 42c54386 on 2.x
- Status changed to RTBC
8 months ago 5:06am 9 May 2024 - 🇪🇸Spain fjgarlin
The issue is fixed in dev and stage now.
- See this (fixed): https://api.stage.cluster.drupalsystems.org/api/drupal/core%21lib%21Drup...
- Vs this (not fixed): https://api.stage.cluster.drupalsystems.org/api/drupal/core%21lib%21Drup...
Once deployed to production, run the following commands:
drush api:re-parse-file /app/git_checkout/api_git_repositories/drupal/11.x/core/lib/Drupal/Core/Render/Element/Container.php 30 drush api:re-parse-file /app/git_checkout/api_git_repositories/drupal/9.5.x/core/lib/Drupal/Core/Render/Element/Container.php 21 drush api:re-parse-file /app/git_checkout/api_git_repositories/drupal/8.9.x/core/lib/Drupal/Core/Render/Element/Container.php 27 drush api:re-parse-file /app/git_checkout/api_git_repositories/drupal/10.3.x/core/lib/Drupal/Core/Render/Element/Container.php 29
- Status changed to Fixed
8 months ago 4:34pm 9 May 2024 - 🇪🇸Spain fjgarlin
The code was deployed to production and the page now looks good.
Thanks for reporting. Automatically closed - issue fixed for 2 weeks with no activity.