Group label required? + WSOD issue

I could be wrong, but looking at the code following the error it looks as though the label should be required.

$new_group->set('id', $this->generateMachineName($new_group->label()));

Thanks both! Unfortunately it's a bit more complicated than that - new group should only be conditionally required if an existing group is not chosen. So we need to implement the validate method of form base.

Ideally we should also extend the save method on the entity itself to throw an exception if someone attempts to create a Site Setting entity programmatically without a Group.

scott_euser → changed the visibility of the branch 3445275-group-label-required to hidden.

Added the validation part of this, but see also related 🐛 WSOD after upgrading from 2.0.0-alpha2 to 2.0.0-alpha3: Drupal\site_settings\Plugin\SiteSettingsLoader\FlattenedSiteSettingsLoader::groupKey(): Argument #1 ($group) must be of type string, null given Fixed . Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.