Contrib.social

Deprecate setting slots with custom tag and attributes

Open on Drupal.org →
Created on 3 May 2024, about 1 month ago
Updated 3 June 2024, 14 days ago

Problem

In 2.x, deprecate passing
$tag = 'div', array $attributes = []
to CustomElement::setSlot(). For that one should use the helper setSlotFromCustomElement() instead.

Mark $tag and $attributes parameters deprecated and do a follow-up to drop them in 3.x

📌 Task
Status

Closed: won't fix

Version

2.0

Component

Code

Created by

🇦🇹Austria fago Vienna

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @fago
  • Status changed to Closed: won't fix 14 days ago
  • Comment 14 days ago →
    🇦🇹Austria fago Vienna

    thinking about this once again, I don't think there is any good reason to deprecate this. Yes, this is somewhat unneeded API since the same can be achieved by creating a custom element and passing it as slot, but that's not as straight forward to do when you just want to create a slot with some html markup.

    I think we can still support this, the code is there, it's not complicating things, so there is no reason to introduce a breaking change here really.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024