Separate configuration of CE field formatters and display components

Created on 3 May 2024, 8 months ago
Updated 21 May 2024, 7 months ago

Problem/Motivation

Right now CE field formatter settings and configuration are using the same array. In core field formatters, settings is a sub-array. Clarify whether we need to follow there. Related, check whether we can make config schema checks work with how we structure entity display config export.

📌 Task
Status

Fixed

Version

3.0

Component

Code

Created by

🇦🇹Austria fago Vienna

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @fago
  • Assigned to fago
  • 🇦🇹Austria fago Vienna
  • 🇦🇹Austria fago Vienna

    Core field formatters store into entity-display component something like

    component-of-field:
       type: <formatter-id>
       settings: <array-of-formatter-settings>
    

    But core field formatters, they auto-generate some plugin configuration which looks the same. So their plugin configuration is something like:

    configuration:
       type: <formatter-id>
       settings: <array-of-formatter-settings>
    

    But in current 3.x branch our ce-field-formatters are having settings and configurations as same thing:

    component-of-ce-field-formatter:
       formatter: <formatter-id>
       settings: <array-of-formatter-settings>
    
    configuration:
       formatter: <formatter-id>
       settings: <array-of-formatter-settings>
       custom-config: <value>
    

    What is very similar. but our plugins can change configuration, not only settings.
    Maybe we need to move it to clear separation:

    component-of-a-formatter:
       formatter: <formatter-id>
       configuration: 
         settings: <array-of-formatter-settings>
         custom-config: <value>
    
  • Merge request !50Separate config → (Merged) created by fago
  • Status changed to Needs review 8 months ago
  • 🇦🇹Austria fago Vienna

    quick draft

  • 🇦🇹Austria fago Vienna

    added some test-coverage to make sure config is passed through to the formatter correctly also. works now, MR is ready

  • 🇦🇹Austria fago Vienna
    • fago committed cd213674 on 3.x
      Issue #3445143 by fago: Separate configuration of CE field formatters...
  • Status changed to Fixed 8 months ago
  • 🇦🇹Austria fago Vienna

    Merged!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024