- Issue created by @fago
- First commit to issue fork.
- Assigned to roderik
- 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
I'm going to just start on this -- I have the feeling I'll pick up opinions about BC (that are now vague) along the way and be better able to articulate them after doing a bit of work.
- Merge request !52Move code from DefaultContentEntityProcessor into CustomElementGenerator. → (Merged) created by roderik
- Status changed to Needs review
8 months ago 10:52pm 8 May 2024 - 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
Needs review for the
So far, this is just moving code around (...) Maybe you want to merge this separately, before I do any real changes.
- 🇦🇹Austria fago Vienna
thx, this seems pretty good already. I dropped a few comments, please take a look!
- Status changed to Needs work
8 months ago 2:06pm 9 May 2024 - Merge request !56Remove CE pre-generation, replace by on-demand generation. → (Merged) created by roderik
- Status changed to Needs review
8 months ago 4:52pm 10 May 2024 - 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
Green, but I need one more nudge/feedback to be sure I need to fix addCeDisplayContent().
If this is considered "not relevant enough for alpha" I'll be happy to do that afterwards. I'm keeping notes on todos which I can transplant to a new issue:
- KernelTest for old situation (or at least look at that at the same time as: )
- clean up other tests and make sure I understand that the expected output is really as expected ( likely at the same time as converting other processors )
- this addCeDisplayContent() discussion. - Status changed to Needs work
7 months ago 11:22pm 12 May 2024 - 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
Hm. After fixing a dumb bug, it turns out I have changed the tests too much.
- Assigned to fago
- Status changed to Needs review
7 months ago 9:38am 13 May 2024 - 🇦🇹Austria fago Vienna
ok, worked over it - as discussed with going with the semantics of "DISABLED" == not-existing as core does it usually also. Also extended test-coverage for making sure the fallback works correctly.
- Status changed to RTBC
7 months ago 9:45am 13 May 2024 - 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
Thanks. Reviewed. No comments.
- Status changed to Fixed
7 months ago 10:11am 13 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.