Secondary navbar tags hidden from view

Created on 3 May 2024, 7 months ago

Problem/Motivation

I am using Social Blue as the base theme for my custom theme. I would like for some roles other than admin (e.g. content manager, publisher) to use the custom theme for moderation pages so they can have a similar UX to the client-facing pages.
When that role navigates to /admin/content (or /admin/content/comment), the secondary navigation tabs are obscured from view. Please see screenshots: 'Secondary navtabs obscured on admin page with custom theme.png', 'Secondary navtabs for gin admin theme.png'.

Steps to reproduce

  1. Install Open Social distribution with Social Blue theme
  2. Enable content moderation module and workflows module
  3. Create a content manager role so they can access /admin/content page and view the content moderation tab.
  4. Configure some permissions - see screenshot 'Permissions example.png'
  5. In permissions, set one of your content manager roles to not have permission to view the admin theme (permission is under the heading: System)
  6. Log in as this content manager role, navigate to /admin/content

Proposed resolution

I believe the secondary tabs could be shown by removing the fixed height set on the div with class of "navbar-scrollable" of 44px. This div is the parent container to the Primary and Secondary Tabs H2 tags as well as the ul tags for the actual links/tabs. Please take a look at screenshot 'remove fixed height solution.png'

But curious to know what was the intention on setting it to an absolute value? I don't find that the navbar scrolls down say, if you have a lot of content below, I checked higher up the DOM and the elements appear to be set position: relative?

MR to update the following file:
In the repo: https://git.drupalcode.org/project/socialblue/-/blob/2.6.x/components/03...

/themes/contrib/socialblue/components/03-molecules/navigation/navbar/navbar--sky.scss
Line 41: remove height: 44px;
recompile Scss

🐛 Bug report
Status

Active

Version

2.5

Component

User interface

Created by

🇬🇧United Kingdom William_Kan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024