\Drupal::config('system.date')->get('country.default') now has validation and can now be null

Thanks for flagging this @nicxvan.

I see that you opened identical issues in a few other projects:

• 📌 \Drupal::config('system.date')->get('country.default') now has validation and can now be null Active
• 📌 \Drupal::config('system.date')->get('country.default') now has validation and can now be null Active
• 📌 \Drupal::config('system.date')->get('country.default') now has validation and can now be null Active
• 📌 \Drupal::config('system.date')->get('country.default') now has validation and can now be null Active

So it seems that this is just a general notification that country.default configuration changed, and any project that references it somewhere in their code might need to make appropriate changes. I appreciate the heads up.

farmOS only references country.default in one place. We expose our own simplified "Configure Farm Info" settings form that allows a user to set the site name, default country, and default timezone in one place.

Here is where country.default is first referenced: https://github.com/farmOS/farmOS/blob/b89621863c4f2430c06c9f6ee5f0a82a31...

I wonder if we need to make any adjustments to this? I think our form will try to save a blank string instead of NULL. It sounds like that might need to change.

Yeah, that's why I created these issue, thanks for reminding me to finish.

The way you use it is one of the reasons we removed the default country from the install page, core didn't use it at all and most contrib just used it like you are here to either set it themselves or use it as a default internally.

If you're not using that value in your system, it might be better to just remove it unless you have plans to use it in the future.

There is some discussion to add it back into the date formatter so that depending on country dates get output as your countries default.

So it might be worth considering. In the minimum I think what you mentioned is line 96 should be NULL instead of ''

Ah good to know thanks!

We aren't using it anywhere ourselves, so I suppose we could consider removing it, if that's the direction core is headed. The timezone is the more important one for us.

I opened a pull request to propose removing country.default from our settings form: https://github.com/farmOS/farmOS/pull/840

If that gets merged, we can close this.

PR was merged.

Automatically closed - issue fixed for 2 weeks with no activity.