Syntax error (unexpected 'bool', expecting function or const) when running the process command

Open on Drupal.org →

Created on 1 May 2024, 11 months ago

Updated 2 May 2024, 11 months ago

Drupal version

8.9.20 (PHP 7.3)

Drupal Rector version

0.20.1

Problem / Motivation

I installed drupal rector as per docs with composer, I copied the rector.php file and if I run i.e.

vendor/bin/rector process web/modules/custom/[some_custom_module] --dry-run

I get this error

[ERROR] syntax error, unexpected 'bool' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST)

If I don't copy the rector.php file, rector create its own and it works (but obviously it doesn't contain the Drupal stuff, it only adds the void return type for functions/method that doesn't return anything, that's not even mentioned in upgrade_status as an issue)

I debugged a bit with and it seems to fail when trying to set the setlists

    $rectorConfig->sets([
        Drupal8SetList::DRUPAL_8,
        Drupal9SetList::DRUPAL_9,
        Drupal10SetList::DRUPAL_10,
    ]);

specifically it seems to fail when it does (for any of the set list i tried)

    $rectorConfig->singleton(AddCommentService::class, function () {
        return new AddCommentService();
    });

after that i'm getting a bit lost on why/what's happening honestly... Does anybody experienced something similar?

🐛 Bug report

Status

Active

Component

Code

Created by

🇮🇹Italy FrancescoQ

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @FrancescoQ
Comment 11 months ago →
🇮🇹Italy FrancescoQ
I found the issue: I further investigated, with xdebug and I got a bit more specific error:
ParseError: syntax error, unexpected 'bool' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) in /var/www/html/vendor/palantirnet/drupal-rector/src/Services/AddCommentService.php on line 16

That class uses typed properties, that cannot work with PHP 7.3 but only with PHP 7.4+

I don't know why composer allowed me to install the package without complaining (maybe it doesn't have the correct php requirement set in the composer.json?) anyway now it seems to work properly!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024