Faint Bullets Appearing Next to Icons

Created on 30 April 2024, 8 months ago
Updated 29 August 2024, 4 months ago

Problem/Motivation

I'm using the DXPR theme on a Drupal 10 website. And after adding some social media icons and links via this module, everything looks great except there are faint bullets showing next to each social icon.

See the attached screenshot: the bullets are faint, but you can definitely see them.

I checked the CSS and it appears that list-style-type: none; as it should be. And I can't find anything else to change on the CSS side, so I'm thinking this must be coming from your code in a way that I can't remove on the front end.

Thanks for looking into this, and I'll be happy to provide any further info. it needed.

๐Ÿ’ฌ Support request
Status

Needs review

Version

2.9

Component

Miscellaneous

Created by

๐Ÿ‡บ๐Ÿ‡ธUnited States jimmb

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @jimmb
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia ravi kant Jaipur

    ravi kant โ†’ made their first commit to this issueโ€™s fork.

  • Merge request !35Fixed to overlaping style issue โ†’ (Open) created by ravi kant
  • Pipeline finished with Success
    7 months ago
    Total: 144s
    #173983
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia ravi kant Jaipur

    @jimmb
    The issue is appearing only in the footer region of the DXPR theme because the style of the footer region is applied to social media links.
    It can be fixed in the theme but I am fixing it in the module assuming that it may appear frequently.

  • Status changed to Needs review 7 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia ravi kant Jaipur
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States jimmb

    Thanks @ravi, your solution looks like exactly what is needed!

    I see the status now is "needs review".

    Let me know if there is something you'd like me to do to help review your fix. Otherwise, I look forward to seeing a new module version release that includes the fix.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia ravi kant Jaipur

    @jimmb
    The "Need Review" status is for review/testing the changes by Testers(QA). When these changes are reviewed and all goods then it will move to "Reviewed & tested by the community".

    After the "Reviewed & tested by the community" status, the maintainers will check the changes and merge them into actual code.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States jimmb

    Thanks for the reply, ravi - much appreciated. So it sounds like you're handling the QA testing side, and I'm not sure who is doing the community reviewing and testing (but I assume that is covered as well) ...

    So fro now, I'll be patient and wait for the next module update. I'm just about ready otherwise to make this website live, so you can understand why I'm looking forward to this being ready as well!

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia ravi kant Jaipur

    @jimmb
    You can apply a patch of my changes.
    Because changes will be reflected in the new release of the module after merging MR and new release process may take a long time.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States jimmb

    Hello - I believe there have been 2 incremental updates to this module since I posted this issue. And after applying the most recent update a couple days ago, I'm still seeing the faint bullets.

    I'm also not sure why the issue status is still at 'Needs Review', when it sounded like there was a clear fix?

    So it makes me wonder - are you expecting me to apply the patch and review this? Personally, I'm a low-code/no-code site builder and am hesitant to apply patches or do things like that unless it's *absolutely* necessary. I was assuming you would have a way of reviewing this on your side as well...

    So I'm just wondering if I need to do something further, or if I just need to keep being patient (very patient) for this tomake it into an upcoming release.

Production build 0.71.5 2024