Don't redirect on asset generation paths

Created on 30 April 2024, 7 months ago
Updated 17 June 2024, 5 months ago

After upgrading my Drupal installation to 10.1.x CSS/JS aggregation no longer seemed to work. After some research it appears Anonymous Redirect is instructing a redirect for the sites/default/files/js/* and sites/default/files/css/* paths.

Unsure, but might be related to the changes in [#2888767]?

🐛 Bug report
Status

Needs review

Version

2.0

Component

Code

Created by

🇧🇪Belgium rp7

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @rp7
  • Pipeline finished with Failed
    7 months ago
    Total: 198s
    #160659
  • Issue was unassigned.
  • Status changed to Needs review 7 months ago
  • 🇧🇪Belgium rp7

    MR opened + patch attached.

  • Status changed to Needs work 7 months ago
  • 🇦🇺Australia mstrelan

    Left some nits and a question about compatibility. Test coverage would be good if possible.

  • Pipeline finished with Canceled
    7 months ago
    Total: 99s
    #162483
  • Pipeline finished with Failed
    7 months ago
    Total: 140s
    #162486
  • Pipeline finished with Success
    7 months ago
    #162497
  • Pipeline finished with Failed
    7 months ago
    Total: 140s
    #162504
  • Pipeline finished with Success
    7 months ago
    Total: 138s
    #162515
  • Pipeline finished with Success
    7 months ago
    Total: 139s
    #162517
  • Pipeline finished with Success
    7 months ago
    #162519
  • 🇧🇪Belgium rp7

    Made a few proposed changes + tried to get the tests green.
    A test for an actual asset generation path should still be added, though.

  • 🇦🇺Australia mstrelan

    Needs a rebase

  • Status changed to Needs review 5 months ago
  • 🇦🇺Australia mstrelan

    Rebased and started looking at test coverage, but one glaring issue is that the asset generation directory by default is the same as the public file system. This might be ok though, since it's usually served directly by apache anyway, except for the image styles directory.

Production build 0.71.5 2024