Created on 26 April 2024, 3 months ago
Updated 14 June 2024, 29 days ago

Add the Gitlab CI file so that syntax is checked.

πŸ› Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States kelly.m.jacobs

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @kelly.m.jacobs
  • Merge request !13Resolve #3443802 "Add gitlab ci" β†’ (Merged) created by kelly.m.jacobs
  • First commit to issue fork.
  • πŸ‡ΊπŸ‡ΈUnited States wylbur Minneapolis, Minnesota, USA

    I reviewed the issue and code.

    The .gitlab-ci.yml looks good, I ran it through cs-lint on gitlab, and it passed.
    Status:
    Syntax is correct. CI configuration validated, including all configuration added with the include keyword.

    I did have a question about the commit to "Remove test files that are not testing Workflow Buttons functionality" - did you intent to remove all the test files?

    Will leave this issue as needs review. Let me know if there are other actions that need to be done to verify this issue.

  • πŸ‡―πŸ‡΅Japan ultrabob Japan

    Thanks for the review wylbur! I started trying to fix the tests, and when I looked into them deeper, it appeared to me that the tests had been copied from elsewhere, and were not testing the functionality of this module. We need a follow-up issue to add some test coverage for the module.

  • πŸ‡―πŸ‡΅Japan ultrabob Japan
  • Pipeline finished with Success
    2 months ago
    Total: 149s
    #170730
  • Status changed to RTBC 2 months ago
  • πŸ‡ΊπŸ‡ΈUnited States wylbur Minneapolis, Minnesota, USA

    @ultrabob, after spending some time trying to get test working, I totally agree with you! I'll create a new issue, and work on some fixes. Let's stick with deleting tests here, and working on this on a new issue. I'm marking this as RTBC, but let me know if this needs more input.

    Thanks!

  • Status changed to Needs work 2 months ago
  • πŸ‡―πŸ‡΅Japan ultrabob Japan

    @wylbur thanks a lot for your work on this. It looks like at this point we only have three minor phpstan warnings left, which we could add to the baseline and try to fix later, but given that they don't look like hard issues, I think I want to fix them so we can start with fully passing gitlab-ci.

  • Open on Drupal.org β†’
    Core: 9.5.x + Environment: PHP 8.0 & MySQL 5.7
    last update about 1 month ago
    Waiting for branch to pass
  • Status changed to Fixed about 1 month ago
  • πŸ‡―πŸ‡΅Japan ultrabob Japan

    Workflow Buttons now passes all linting and code analysis with no warnings or errors. There is another issue for adding tests, given that the existing tests were not testing Workflow Buttons features.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024