Make editing CE entity display basically work

Open on Drupal.org →

Created on 26 April 2024, 8 months ago

Updated 23 May 2024, 7 months ago

Motivation

Once support for field formatters has been added in 📌 Add support for field formatters Active , we need to make the UI basically work.

Steps to reproduce

Atm the UI saving of CE-formatter settings only works after an AJAX update, e.g. change the name of CE-field, click outside the form-input, such that the ajax reload works. Then a "Save" operation works. If the AJAX update is not happening (e.g. because not clicking outside of the form intput), the save does NOT work.

Proposed resolution

Work over UI and customize / move the CE-field formatters as needed.

📌 Task

Status

Fixed

Version

3.0

Component

Code

Created by

🇦🇹Austria fago Vienna

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!51Make editing CE entity display basically work
Merged
🇦🇹Austria fago
updated 8 months ago

Comments & Activities

Issue created by @fago
Merge request !51Resolve #3443739 "Ui" → (Merged) created by fago
Status changed to Needs work 8 months ago5:04pm 7 May 2024
Comment 8 months ago →
🇦🇹Austria fago Vienna
WIP
Comment 8 months ago →
🇦🇹Austria fago Vienna
Got it basically working. I've worked quite over the form. There are a few todos left, but I think it'S better to merge now, since we have something working, and do small todos in follow-ups. That helps to avoid merge issues with other MRs.

todos:
- Merge CustomElementsEntityDisplayFormBase into EntityCustomElementsDisplayEditForm
- Empty plugin settings forms should not see a "settingsForm" edit icon
- Fix editing keys and pressing save bug

Comment 8 months ago →

fago → committed c0c60aae on 3.x

Issue #3443739 by fago: Make editing field formatters settings and ce-...

Status changed to Fixed 8 months ago2:04pm 9 May 2024
Comment 8 months ago →
🇦🇹Austria fago Vienna
Comment 7 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024