- Issue created by @Aziza Anwari
- Assigned to Gurkawal
- Status changed to Needs review
2 months ago 8:07am 26 April 2024 - 🇨🇦Canada ryanrobinson_wlu
I tried this patch as I was looking for the same thing. The general idea works, but I have a couple suggestions.
One is the upgrade path if this is added when you already have a button. I had an existing button that was set to only allow the Teaser display mode and was showing the caption and alignment options. After adding the patch, all of those options went to blank, meaning all the display modes showed up as options and caption/alignment did not. I think this should maintain existing settings as the default: whatever I previously had in display mode, and caption/alignment on. Imagining this coming through as a release, some would be surprised to have the behaviour changed.
The second is that now the second page is unnecessary. The first page I select the entity I want to embed. The second page only shows me that same entity name again. Can that second page be skipped entirely if there are no options on it?