- Issue created by @phenaproxima
- Status changed to Active
4 months ago 6:18pm 30 April 2024 - 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
AFAICT #3427118: If config rollback fails validation, it's impossible to tell what caused the rollback in the first place → didn't fix anything, and just is asserting that the same unhelpful error message that occurs during the rollback is actually printed to the CLI?
Isn't the root cause that
\Drupal\Core\EventSubscriber\ConfigImportSubscriber::validateModules()
observes that the rollback changescore.extension
and then "helpfully" observes thatcore.extension
cannot be modified until thefilter.format.plain_text
text format stops using themedia_embed
filter, whichcore/tests/fixtures/recipes/config_rollback_exception/recipe.yml
just added to that text format?Doesn't that then mean that we:
- either need to make
ConfigImportSubscriber::validateModules()
smarter - or perform the rollback operation in two stages: first revert everything except for
core.extension
changes, and THEN perform thecore.extension
rollback, which would prevent triggering this exception inConfigImportSubscriber::validateModules()
?
- either need to make
- 🇺🇸United States phenaproxima Massachusetts
Yes - it means things in core need to change.
But that's not in scope of the recipe system. (I had raised this same concern with @alexpott.)
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Well it is a bug that you can not uninstall filter format providing modules in one step via the config importer. That's nothing to do with recipes and this situation can happen outside of recipes.