Contrib.social

Fast404 path checking with Redirect module language UND

Open on Drupal.org →
Created on 24 April 2024, 6 months ago
Updated 10 July 2024, 3 months ago

Problem/Motivation

This is a followup of 🐛 Fast404 path checking is incompatible with Redirect module Fixed which added support for the redirect module. The redirect module allows redirects to be added with langcode 'UND' (LanguageInterface::LANGCODE_NOT_SPECIFIED). We should probably check for this as well.

Steps to reproduce

  • Create a redirect for langcode LanguageInterface::LANGCODE_NOT_SPECIFIED in a multilangual environment.
  • Enable Fast404 with path checking and redirect support.
  • Verify the redirect does not work as expected.

Proposed resolution

Add an extra check for langcode LanguageInterface::LANGCODE_NOT_SPECIFIED

Remaining tasks

  • Write a patch
  • Review
  • Commit

User interface changes

-

API changes

-

Data model changes

-

🐛 Bug report
Status

Needs review

Version

3.0

Component

Code

Created by

🇳🇱Netherlands seanB Netherlands

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @seanB
  • Status changed to Needs review 6 months ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
    last update 6 months ago
    6 pass
  • Comment 6 months ago →
    🇳🇱Netherlands seanB Netherlands

    Patch is attached

  • Comment 3 months ago →
    🇺🇸United States fizcs3 Omaha, Nebraska; USA

    Thank you @seanB, just ran into this issue with redirects going to 404 page that have language not specified / "-All languages-"...

    Confirming that patch #2 fixes this for me, and applies successfully to:
    * fast_404:8.x-3.3
    * Drupal 10.2.7
    * PHP 8.2.19

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024