Installation blocked on 3.x branch

Created on 24 April 2024, 8 months ago
Updated 6 September 2024, 4 months ago

Problem/Motivation

When upgrading a site from CKEditor 4 to CKEditor 5, it may be necessary to have both modules installed and enabled at once.

The ckeditor_iframe_requirements() code only checks that CKEditor 4 is installed, and will not let you proceed with installation if the iFrame library is missing.

If you plan to use the module only with CKEditor 5, it is not possible to install without first installing a redundant CKEditor 4 iFrame plugin.

Steps to reproduce

1. Install a new Drupal 10 install
2. Install CKEditor 4 and CKEditor 5 modules.
3. Try to install this module without first installing the CKEditor 4 library.

Proposed resolution

Change REQUIREMENT_ERROR to REQUIREMENT_WARNING in ckeditor_iframe.install.

πŸ› Bug report
Status

Needs review

Version

3.0

Component

Code

Created by

πŸ‡¬πŸ‡§United Kingdom mattjones86 πŸ‡¬πŸ‡§ GMT+0

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mattjones86
  • πŸ‡¬πŸ‡§United Kingdom mattjones86 πŸ‡¬πŸ‡§ GMT+0
  • Status changed to Needs review 8 months ago
  • πŸ‡¬πŸ‡§United Kingdom mattjones86 πŸ‡¬πŸ‡§ GMT+0
  • Status changed to Postponed: needs info 6 months ago
  • πŸ‡ΊπŸ‡ΈUnited States bkosborne New Jersey, USA

    Hmm... are you sure? That whole code block is wrapped in an if statement that only executes when the "ckeditor" module is installed (CKEditor 4). So if you don't have CKE4 installed, then it shouldn't block anything when attempting to install this module.

  • Status changed to Closed: cannot reproduce 4 months ago
  • πŸ‡³πŸ‡±Netherlands firfin

    I did not have this problem when installing without CKE4.
    Also no activity from OP, so I think this can go on the closed pile :-)

  • πŸ‡¬πŸ‡§United Kingdom mattjones86 πŸ‡¬πŸ‡§ GMT+0

    Sorry I've not been on Drupal in a while but if I recall, the problem mainly happens when trying to perform a migration from CKEditor 4 to CKEditor 5, in which case you may have both modules installed at the same time.

    If you only want to use this plugin on CKEditor 5 you cannot, because installation is blocked unless you also install the separate CKEditor 4 library.

  • πŸ‡¬πŸ‡§United Kingdom mattjones86 πŸ‡¬πŸ‡§ GMT+0
  • Status changed to Needs review 4 months ago
  • πŸ‡¬πŸ‡§United Kingdom mattjones86 πŸ‡¬πŸ‡§ GMT+0

    I have provided more detail, sorry my original explanation was not the best!

Production build 0.71.5 2024