Contrib.social

[Regression] Previously selected link cannot be selected again after #3422951

Open on Drupal.org →
Created on 23 April 2024, 7 months ago
Updated 21 May 2024, 7 months ago

Problem/motivation

The change in ✨ Allow listening to suggestion being selected Fixed seems to have caused some very specific regression within the Ckeditor linkit widget.
When a link to a specific item was made, and you try to add that same link again; it will not be selected.

Steps to reproduce

  1. Create a node to link to, title example: "My page"
  2. Create a link to "My page" in any ckeditor widget; via the linkit autocomplete selection, it will automatically be replaced to /node/1.
  3. Enter "My page" again in the autocomplete widget. After selection, it will not be replaced to /node/1. The autocomplete search query will stay in the link field. Any other autocomplete result will work just fine, however.

When using linkit 6.1.2, this works as expected.

Proposed resolution

This module uses Gitlab CI for automated testing of proposed code changes. To contribute code changes, create a merge request. Patch files will not trigger automated testing and are not sufficient for review.
🐛 Bug report
Status

Active

Version

7.0

Component

Code

Created by

🇺🇸United States mark_fullmer Tucson

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @mark_fullmer
  • Comment 7 months ago →
    🇺🇸United States mark_fullmer Tucson
  • Comment 7 months ago →
    🇺🇸United States sclsweb

    Another, more common (at least for the content creators I support), use case scenario where this regression happens is:

    1. Create a node to link to, title example: "My page"
    2. Create a link to "My page" in any ckeditor widget; via the linkit autocomplete selection, it will automatically be replaced to /node/1; BUT, because you are human, forget to check the green check mark to finish making the link. Click anywhere outside the link dialog. No link is created.
    3. Try to redo making the failed link. Enter "My page" again in the autocomplete widget. After selection, it will not be replaced to /node/1. The autocomplete search query will stay in the link field.
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024