- Issue created by @stefan.korn
- Issue was unassigned.
- Status changed to Needs review
3 months ago 9:55am 14 November 2024 - 🇩🇪Germany stefan.korn Jossgrund
I am using this for a while now, so setting to "Needs review"
This module allows to add own social media by using the social_media.add_more_link event. This is a great idea which brings great flexibility.
However the configuration for these added social media is saved together with the basic configuration in social_media.settings. This does work, but the additional social media is not handled correct from a configuration point of view. There is no configuration schema in social_media.schema.yml for these new social media. Though this is no big deal in terms of functionality, the configuration is not valid in drupal terms.
My proposal would be to split configuration from social media module and other modules that extend via the social_media.add_more_link event. That way one could have a valid config in one's own module. This would also allow to provide just the config for the new social media in your own module (via config/install) and leave the social_media.settings alone. This would allow to provide a custom (or contrib module) that just adds the new social media without tinkering with the social_media modules settings.
I will provide changes in a new branch for this and create a merge request.
Active
2.0
Code
I am using this for a while now, so setting to "Needs review"