Contrib.social

Make OrangeDamApi::getKeywords a pure get function

Open on Drupal.org →
Created on 18 April 2024, 12 months ago
Updated 10 May 2024, 11 months ago

Problem/Motivation

Currently, OrangeDamApi::getKeywords() retrieves keywords, packages them as OrangeDamKeywordItems and Queues them. The latter two operations should be handled by OrangeDamQueueDataManager.

Since the only two calls to OrangeDamApi:getKeywords() are in OrangeDamQueueDataManager, resolving this is pretty straightforward. This allows OrangeDamApi::getKeywords() to do _only_ what it says on the label, and, once the queueing is moved over to OrangeDamQueueDataManager still allows the application to behave exactly as before.

Proposed resolution

Move the following code to OrangeDamQueueDataManager:

        $this->migrationDataManager->queueMigrationItem($keyword);

Remaining tasks

Create a merge request with the suggested improvement.

User interface changes

Will allow implementors to use OrangeDamApi to just retrieve data, without also queuing it.

API changes

none.

Data model changes

none

✨ Feature request
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States apotek

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024