Fix video list api endpoint

Copy of patch from https://git.drupalcode.org/project/bridtv/-/merge_requests/13.diff attached, to be used with composer, see "Patches from drupal.org merge request URLs are dangerous?".

Thanks for the report and providing a patch. I've seen that current maintainers of 2.0.x are not really active here. @osopolar Do you want to become a maintainer of this project?

What's a bit strange to me is that the URL endpoint seems to not work properly now, but used to work earlier, otherwise this client integration should've not worked from the beginning?

@mxh If you want I can minimally maintain the module, as long as we are using it, otherwise I won't be able to test.

I am wondering the same, because for us it also worked before. To me it looks like that BridTV updated it's API. Maybe they just turned off legacy functionality as otherwise a new api version should have been introduced. I will try to figure out what happened and also check what happened to the /players/catalog/{id}.json endpoint.

@osopolar I've added you as a maintainer to the project.

I got feedback from BridTV why the API stopped working for us:

… the legacy functions have been cut. We announced the deprecation of APIv2 to APIv3. After APIv3 came out live, the endpoint "videos" led towards legacy functions, which were enabled for some time after the release. After we ensured we gave enough time, the endpoint "videos" was cut as a legacy function and now a new endpoint "video" must be used. This endpoint is leading to the APIv3. (bearbeitet)

I also asked what happened to endpoint: https://api.brid.tv/apiv3/players/catalog/{partner_id}.json

The mentioned endpoint was also deprecated with APIv2. Now on the APIv3, please be sure to use the following endpoint:
https://api.brid.tv/apiv3/player/list/{partner_id}.json

You can also find it in our documentation here:
https://developer.brid.tv/reference/listplayer

@mxh The changes where not as trivial as thought as it was not only about modifying the endpoints but also implementing functionality of the new api, as legacy functions from and older api got removed. May you be so kind and review the changes? Or maybe ping others to review, in case you know somebody who is using the module. The syncing must have stopped for them too.

Copy of patch from !MR13 attached, for save use with composer.

@mhx I did not understand the following code in \Drupal\bridtv\Plugin\QueueWorker\BridSyncWorker::processRemoteList(), therefore I did not touch it. Maybe something fundamental also changed regarding this code. May you check? $pagination['nextPage'] seems to be boolean and $pagination['page'] integer:

    // In case we are not on the last page yet, throw the next
    // item into the queue to continue processing.
    if (!empty($data['q_next']) && !(empty($pagination['nextPage']) || ($pagination['nextPage'] == $pagination['page']))) {
        $sync->queueRemoteListItem($pagination['nextPage'], TRUE);
    }

lgtm

I'm sorry I'm not available.

osopolar → closed merge request !18

osopolar → reopened merge request !18

Automatically closed - issue fixed for 2 weeks with no activity.