- Issue created by @neclimdul
- π¨π¦Canada gapple
It might not be possible to get around this conflict without core changes that allow everyone to decorate instead of replace the service
#3096061: [upstream] html_response.attachments_processor service must be replaced instead of decorated β - π¨π¦Canada gapple
Looks like Webprofiler has a decoration solution now:
https://git.drupalcode.org/project/webprofiler/-/commit/43e8aba836c7a696...(though this:
$this->dataCollector->setPlaceholders($attachments['big_pipe_placeholders'] ?? []);
looks like it might not handle core's placeholders when bigpipe is disabled -$attached['html_response_attachment_placeholders']
) - πΊπΈUnited States neclimdul Houston, TX
oh that looks promising. That does look a bit off but it's just their collection so shouldn't be a big deal.
Still agreed core needs a better setup in core but this should solve the immediate issue once its released.
- Status changed to Closed: duplicate
6 months ago 5:47am 22 May 2024 - π¨π¦Canada gapple
With webprofiler's change I think this is no longer a problem. The older issue has details on changes needed in core to prevent future conflicts if another module needs to replace the same service.