- Issue created by @chr.fritsch
- Status changed to Needs review
12 months ago 7:17am 16 April 2024 - Status changed to RTBC
12 months ago 7:17am 23 April 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
I like it! π
Awaiting test result for https://git.drupalcode.org/issue/config_inspector-3441111/-/jobs/1337191 β if that gets as far as HEAD does (Drupal 11 bumped requirements a few days ago and hence broke builds: π Core config validatibility CI job stopped working on April 20 because Drupal core now requires SQLite 3.45 Fixed ), then I'll merge π
- π©πͺGermany chr.fritsch π©πͺπͺπΊπ
It's impossible to get this MR completely green. You can choose between coding standards and PHP 7 compatibility π
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
That's absurd π¬π«£
But I wonder if that's just because
phpcs
targets changed with last week's release ofdrupal/coder:8.3.24
β¦ so fixing those violations in HEAD first: π PHPCS CI job fails since drupal/coder:8.3.24 Needs review . - Assigned to wim leers
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
π PHPCS CI job fails since drupal/coder:8.3.24 Needs review is fixed, merging that into this MR nowβ¦
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
I see what you're saying now, @chr.fritsch π¬
2) Drupal\Tests\config_inspector\Kernel\ConfigInspectorManagerTest::testGetDefinitionsMethod ParseError: syntax error, unexpected ')', expecting variable (T_VARIABLE) /builds/project/config_inspector/src/ConfigInspectorManager.php:56 β¦
β https://git.drupalcode.org/project/config_inspector/-/jobs/1475798
I'll just disable PHPCS in the places where the PHPCS rules force us to drop PHP 7 compatibility π
- Issue was unassigned.
-
Wim Leers β
committed 77d5f5e3 on 2.1.x authored by
chr.fritsch β
Issue #3441111 by chr.fritsch, Wim Leers: Add --generate-baseline and --...
-
Wim Leers β
committed 77d5f5e3 on 2.1.x authored by
chr.fritsch β
- Status changed to Fixed
11 months ago 9:22am 30 April 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Thanks for this valuable addition, @chr.fritsch! π₯³
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Automatically closed - issue fixed for 2 weeks with no activity.