Move navigation.navigation_block.administration_menu to config/optional folder

Created on 15 April 2024, 5 months ago
Updated 29 April 2024, 5 months ago

We have failing tests in Add the new Navigation to core as an Experimental module Fixed due to missing dependency system.menu.admin

ModuleConfigureRouteTest installs system module, but it does not installs system's config as part of setup(). When installing navigation as part of testModuleConfigureRoutes, dependency is missing.

To avoid this failing test and some other possible edge case errors, navigation.navigation_block.administration_menu should be moved to config/optional folder. This ensures that navigation block will be created if only the dependencies are already there.

Given that system configuration is there for core default profiles, this change will be transparent for them.

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇪🇸Spain plopesc Valladolid

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @plopesc
  • Pipeline finished with Success
    5 months ago
    Total: 341s
    #146829
  • Status changed to Needs review 5 months ago
  • 🇪🇸Spain plopesc Valladolid

    Move to NR

  • Status changed to RTBC 5 months ago
  • 🇨🇦Canada m4olivei Grimsby, ON

    Looks great! Nice catch.

  • Pipeline finished with Skipped
    5 months ago
    #147117
  • 🇨🇦Canada m4olivei Grimsby, ON
  • Status changed to Fixed 5 months ago
  • 🇨🇦Canada m4olivei Grimsby, ON

    Merged to 1.x 🎉. Thanks.

  • Status changed to Needs review 5 months ago
  • 🇪🇸Spain plopesc Valladolid

    New MR adding required missing dependencies in default config

  • Pipeline finished with Success
    5 months ago
    Total: 221s
    #147178
  • Pipeline finished with Skipped
    5 months ago
    #147191
  • Pipeline finished with Skipped
    5 months ago
    #147192
  • Status changed to RTBC 5 months ago
  • 🇨🇦Canada m4olivei Grimsby, ON

    Looks good. I've merged it. Will update core inclusion MR and then if we get a green result, we'll mark this issue as fixed.

  • Pipeline finished with Canceled
    5 months ago
    Total: 13s
    #147294
  • Pipeline finished with Failed
    5 months ago
    Total: 238s
    #147295
  • Pipeline finished with Success
    5 months ago
    Total: 229s
    #147303
  • Status changed to Needs review 5 months ago
  • 🇪🇸Spain plopesc Valladolid

    @m4olivei

    There were some unrelated test fails due to 📌 [Meta] Fix all tests that rely on UID1's super user behavior Active . Worked on them here to avoid creating a new issue.

    Fixed them, I hope we don't have more unexpected conflicts here.

  • Pipeline finished with Skipped
    5 months ago
    #147307
  • Status changed to RTBC 5 months ago
  • 🇨🇦Canada m4olivei Grimsby, ON

    Looks good. Tests passing and Tugboat looks fine. Merging and will update core MR.

  • Status changed to Fixed 5 months ago
  • 🇨🇦Canada m4olivei Grimsby, ON

    The core inclusion MR is now green! Thanks for chasing all of these down @plopesc!

  • Pipeline finished with Success
    5 months ago
    #155058
  • Pipeline finished with Success
    5 months ago
    Total: 618s
    #157399
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Failed
    30 days ago
    Total: 56s
    #261308
  • Pipeline finished with Failed
    30 days ago
    Total: 273s
    #261297
  • Pipeline finished with Failed
    30 days ago
    Total: 54s
    #261326
  • Pipeline finished with Failed
    30 days ago
    Total: 224s
    #261318
  • Pipeline finished with Failed
    30 days ago
    Total: 52s
    #261360
  • Pipeline finished with Failed
    28 days ago
    Total: 141s
    #262835
  • Pipeline finished with Failed
    26 days ago
    Total: 57s
    #264727
  • Pipeline finished with Failed
    26 days ago
    Total: 325s
    #264732
  • Pipeline finished with Failed
    26 days ago
    Total: 109s
    #264753
  • Pipeline finished with Failed
    26 days ago
    Total: 51s
    #264762
  • Pipeline finished with Failed
    26 days ago
    Total: 56s
    #264778
  • Pipeline finished with Failed
    25 days ago
    Total: 50s
    #265794
  • Pipeline finished with Failed
    25 days ago
    Total: 48s
    #265803
  • Pipeline finished with Failed
    18 days ago
    Total: 48s
    #271593
  • Pipeline finished with Failed
    18 days ago
    Total: 49s
    #271698
  • Pipeline finished with Skipped
    17 days ago
    #273386
  • Pipeline finished with Failed
    16 days ago
    Total: 256s
    #273638
  • Pipeline finished with Failed
    16 days ago
    Total: 680s
    #273641
  • Pipeline finished with Failed
    16 days ago
    Total: 462s
    #273652
  • Pipeline finished with Failed
    16 days ago
    Total: 138s
    #273665
  • Pipeline finished with Failed
    15 days ago
    Total: 53s
    #275497
  • Pipeline finished with Failed
    15 days ago
    Total: 62s
    #275500
  • Pipeline finished with Failed
    15 days ago
    Total: 52s
    #275504
  • Pipeline finished with Failed
    15 days ago
    Total: 52s
    #275516
  • Pipeline finished with Failed
    15 days ago
    Total: 289s
    #275511
  • Pipeline finished with Failed
    15 days ago
    Total: 52s
    #275523
  • Pipeline finished with Failed
    14 days ago
    Total: 63s
    #275644
  • Pipeline finished with Success
    9 days ago
    Total: 395s
    #280878
  • Pipeline finished with Success
    9 days ago
    Total: 53s
    #280904
  • Pipeline finished with Success
    9 days ago
    Total: 51s
    #280906
  • Pipeline finished with Success
    9 days ago
    Total: 51s
    #280910
  • Pipeline finished with Success
    9 days ago
    Total: 52s
    #280952
  • Pipeline finished with Success
    9 days ago
    Total: 51s
    #280963
  • Pipeline finished with Success
    3 days ago
    Total: 391s
    #286164
  • Pipeline finished with Success
    2 days ago
    Total: 413s
    #286182
  • Pipeline finished with Failed
    2 days ago
    Total: 414s
    #286191
Production build 0.71.5 2024